Re: [PATCH] Include <unistd.h> for mkostemp and mkostemps on OS X

[Bruno Haible]

Tom Tromey wrote:
> diff --git a/ChangeLog b/ChangeLog
> index 8ef956b36..67091fb1e 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2018-10-01  Tom Tromey  <address@hidden>
> +
> +     * lib/stdlib.in.h: Include <unistd.h> for mkostemp and mkostemps
> +     on OS X.
> +

Thanks, applied.

I updated the documentation accordingly:


2018-10-01  Bruno Haible  <address@hidden>

        mkostemp, mkostemps: Update documentation.
        * doc/glibc-functions/mkostemp.texi: Mention the Mac OS X issue.
        * doc/glibc-functions/mkostemps.texi: Likewise.

diff --git a/doc/glibc-functions/mkostemp.texi 
b/doc/glibc-functions/mkostemp.texi
index 40f3192..c18b2d4 100644
--- a/doc/glibc-functions/mkostemp.texi
+++ b/doc/glibc-functions/mkostemp.texi
@@ -10,6 +10,10 @@ Portability problems fixed by Gnulib:
 This function is missing on many non-glibc platforms:
 Mac OS X 10.5, FreeBSD 6.0, NetBSD 5.0, OpenBSD 3.8, Minix 3.1.8, AIX 5.1, 
HP-UX 11, IRIX 6.5, OSF/1 5.1, Solaris 11.3, Cygwin 1.7.5, mingw, MSVC 14, 
Interix 3.5, BeOS, Android 5.1.
 @item
+This function is declared in @code{<unistd.h>} instead of @code{<stdlib.h>}
+on some platforms:
+Mac OS X 10.13.
address@hidden
 On platforms where @code{off_t} is a 32-bit type, @code{mkostemp} may not work
 correctly to create files larger than 2 GB.  (Cf. @code{AC_SYS_LARGEFILE}.)
 @end itemize
diff --git a/doc/glibc-functions/mkostemps.texi 
b/doc/glibc-functions/mkostemps.texi
index ca018d8..0031146 100644
--- a/doc/glibc-functions/mkostemps.texi
+++ b/doc/glibc-functions/mkostemps.texi
@@ -10,6 +10,10 @@ Portability problems fixed by Gnulib:
 This function is missing on many non-glibc platforms:
 glibc 2.10, Mac OS X 10.5, FreeBSD 6.0, NetBSD 5.0, OpenBSD 3.8, Minix 3.1.8, 
AIX 5.1, HP-UX 11, IRIX 6.5, OSF/1 5.1, Solaris 11.3, Cygwin 1.7.5, mingw, MSVC 
14, Interix 3.5, BeOS, Android 5.1.
 @item
+This function is declared in @code{<unistd.h>} instead of @code{<stdlib.h>}
+on some platforms:
+Mac OS X 10.13.
address@hidden
 On platforms where @code{off_t} is a 32-bit type, @code{mkostemps} may not work
 correctly to create files larger than 2 GB.  (Cf. @code{AC_SYS_LARGEFILE}.)
 @end itemize