bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: timevar: 1/3: expect that getrusage is available


From: Akim Demaille
Subject: Re: timevar: 1/3: expect that getrusage is available
Date: Sat, 13 Oct 2018 06:38:49 +0200


> Le 12 oct. 2018 à 17:27, Bruno Haible <address@hidden> a écrit :
> 
> Hi Akim,
> 
> This patch looks good, except for two things:
>  - The module description still references m4/timevar.m4, which no longer
>    exists.

Fixed, thanks!

>  - The code prints the '.wall' values, which are not initialized. But this
>    is fixed in part 3/3.

They are initialized

static void
set_to_current_time (struct timevar_time_def *now)
{
  now->user = 0;
  now->sys  = 0;
  now->wall = 0;

but yes, they are no yet filled with actual values.  Is this really a
problem?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]