Re: update-copyright is broken

[Bruno Haible]

Hi,

Brian C. Lane wrote:
> I think it was the change in commit a05d5d121b10f24 where it moved and
> changed the exec code at line 1.
> 
> In parted with the latest gnulib I am getting these errors with 'make
> update-copyright'
> 
>   GEN      update-copyright
> Use of uninitialized value $_ in pattern match (m//) at 
> ./build-aux/update-copyright line 167.
> Use of uninitialized value $_ in pattern match (m//) at 
> ./build-aux/update-copyright line 173.
> Use of uninitialized value $ARGV in concatenation (.) or string at 
> ./build-aux/update-copyright line 285.
> : warning: copyright statement not found
> 
> If I edit the new exec line to use the old one, but with -wSx, it works fine:
> 
> eval '(exit $?0)' && eval 'exec perl -wSx -0777 -pi "$0" ${1+"$@"}'
>   & eval 'exec perl -wSx -0777 -pi "$0" $argv:q'
>       if 0;

Thanks for the report. Indeed, a bad regression. Fixed as follows:


2019-07-16  Bruno Haible  <address@hidden>

        update-copyright: Make it work again (regression from 2019-06-15).
        Reported by Brian C. Lane <address@hidden>.
        * build-aux/update-copyright: Add back the -0777, -p, -i options.

diff --git a/build-aux/update-copyright b/build-aux/update-copyright
index 4a9ea7c..b3f6b29 100755
--- a/build-aux/update-copyright
+++ b/build-aux/update-copyright
@@ -134,7 +134,7 @@
 # the script through the perl program found in $PATH.  The '-x' option
 # is essential as well; without it, perl would re-execute the script
 # through /bin/sh.  When executed by  perl, the next two lines are a no-op.
-eval 'exec perl -wSx "$0" "$@"'
+eval 'exec perl -wSx -0777 -pi "$0" "$@"'
      if 0;
 
 my $VERSION = '2018-03-07.03:47'; # UTC