bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

new module 'basename-lgpl'


From: Bruno Haible
Subject: new module 'basename-lgpl'
Date: Sun, 05 Jul 2020 21:20:47 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-179-generic; KDE/5.18.0; x86_64; ; )

GNU gettext and a couple of gnulib modules need only half of the 'dirname-lgpl'
module, namely essentially the 'basename' equivalent function (now called
'last_component').

In order to minimize dependencies, let me split this out into a separate
module.

So, 'dirname-lgpl' now depends on 'basename-lgpl'.

Also, let me enhance the documentation of function 'last_component'.
In particular, the documentation should state
  - what is the return value in case of a trailing slash,
  - why it is called 'last_component' and not 'basename',
  - what is the different w.r.t. glibc 'basename'.


2020-07-05  Bruno Haible  <bruno@clisp.org>

        mkancesdirs: Trim module dependencies.
        * lib/mkancesdirs.c: Include filename.h instead of dirname.h.
        * modules/mkancesdirs (Depends-on): Remove dirname-lgpl. Add filename.

2020-07-05  Bruno Haible  <bruno@clisp.org>

        getprogname: Trim module dependencies.
        * lib/getprogname.c: Include basename-lgpl.h instead of dirname.h.
        * modules/getprogname (Depends-on): Remove dirname-lgpl. Add
        basename-lgpl.

2020-07-05  Bruno Haible  <bruno@clisp.org>

        filenamecat-lgpl: Trim module dependencies.
        * lib/filenamecat-lgpl.c: Include basename-lgpl.h, filename.h instead of
        dirname.h.
        * modules/filenamecat-lgpl (Depends-on): Remove dirname-lgpl. Add
        basename-lgpl, filename.

2020-07-05  Bruno Haible  <bruno@clisp.org>

        backupfile, backup-rename: Trim module dependencies.
        * lib/backupfile.c: Include basename-lgpl.h instead of dirname.h.
        * modules/backupfile (Depends-on): Remove dirname-lgpl. Add
        basename-lgpl.
        * modules/backup-rename (Depends-on): Likewise.

2020-07-05  Bruno Haible  <bruno@clisp.org>

        argp: Trim module dependencies.
        * lib/argp-namefrob.h: Include basename-lgpl.h instead of dirname.h.
        * modules/argp (Depends-on): Remove dirname-lgpl. Add basename-lgpl.

2020-07-05  Bruno Haible  <bruno@clisp.org>

        basename-lgpl: New module.
        * lib/basename-lgpl.h: New file, based on lib/dirname.h and
        lib/basename-lgpl.c.
        * lib/basename-lgpl.c: Include basename-lgpl.h, not dirname.h. Include
        <stdbool.h>, filename.h.
        (last_component): Rename a local variable.
        * lib/dirname.h: Include basename-lgpl.h.
        (DOUBLE_SLASH_IS_DISTINCT_ROOT): Remove macro.
        (last_component, base_len): Remove declarations.
        * modules/basename-lgpl: New file.
        * modules/dirname-lgpl (Files): Remove lib/basename-lgpl.c.
        (Depends-on): Add basename-lgpl. Remove double-slash-root.
        (Makefile.am): Don't compile basename-lgpl.c.
        * doc/posix-functions/basename.texi: Mention the module 'basename-lgpl',
        not 'dirname'.

2020-07-05  Bruno Haible  <bruno@clisp.org>

        dirname, dirname-lgpl: Simplify.
        * m4/dirname.m4: Remove file.
        * modules/dirname (configure.ac): Don't invoke gl_DIRNAME.
        * modules/dirname-lgpl (Files): Remove m4/dirname.m4.
        (configure.ac): Don't invoke gl_DIRNAME_LGPL.

Attachment: 0001-dirname-dirname-lgpl-Simplify.patch
Description: Text Data

Attachment: 0002-basename-lgpl-New-module.patch
Description: Text Data

Attachment: 0003-argp-Trim-module-dependencies.patch
Description: Text Data

Attachment: 0004-backupfile-backup-rename-Trim-module-dependencies.patch
Description: Text Data

Attachment: 0005-filenamecat-lgpl-Trim-module-dependencies.patch
Description: Text Data

Attachment: 0006-getprogname-Trim-module-dependencies.patch
Description: Text Data

Attachment: 0007-mkancesdirs-Trim-module-dependencies.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]