Re: wget 1.21 fails to build on macOS

[darnir]

I've pulled the latest gnulib into Wget master already.

It will be part of the next point release.

On January 1, 2021 11:32:55 AM GMT+01:00, FX <fxcoudert@gmail.com> wrote:

Hello all,

wget 1.21 fails to build from source on all macOS version (10.14, 10.15, and 11). This comes from a bug in gnulib, as I understand it:
In lib/utime.c, in the code block for REPLACE_FUNC_UTIME_FILE, errno and EOVERFLOW are both used without <errno.h> being included, leading to:

utime.c:279:38: error: use of undeclared identifier 'errno'
      if (stat (name, &buf) == -1 && errno != EOVERFLOW)
                                     ^
utime.c:279:47: error: use of undeclared identifier 'EOVERFLOW'
      if (stat (name, &buf) == -1 && errno != EOVERFLOW)
                                              ^
2 errors generated.
make[3]: *** [utime.o] Error 1

See https://github.com/Homebrew/homebrew-core/pull/68095 for full build log


This was already reported to gnulib at https://lists.gnu.org/archive/html/bug-gnulib/2020-12/msg00295.html
and fix in https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=6a76832db224ac5671599ce332717f985a2addc7

Could the fix please be applied to wget as well?

Thanks,
FX Coudert

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.