Re: clang++ 11 compilation issues

[Paul Eggert]

On 1/13/21 5:21 PM, Bruno Haible wrote:
> For example, say, someone use g++ version >= 5 with option -std=c++98. Then,
> with your new code, __cpp_static_assert will be undefined,
> _GL_HAVE__STATIC_ASSERT will be 1, and _GL_VERIFY(R, DIAGNOSTIC, ...) will
> expand to
>    _Static_assert (R, DIAGNOSTIC)
> which most likely leads to a syntax error.

Thanks, I see your point. (I had to use -std=gnu++98 to observe the 
problem.)

How about the attached, more-conservative patch instead? It limits 
__cpp_static_assert to controlling the use of 'static_assert', and 
causes C++ code to not use _Static_assert at all.

> Also note that the C++ test coverage of this module is currently zero (none).
> This means that if you make this change and it is buggy, we have no way to
> catch it, before some user will stumble across it.

The users in this case are developers, and the failure mode is merely a 
trivial failure to compile, so these problems should be relatively 
minor. And when things go wrong (as they likely will regardless of 
whether this patch is installed :-), having a simpler verify.h will ease 
users' jobs.

0001-verify-simplify-static_assert-configuration.patch
Description: Text Data