bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ptsname_r on Cygwin


From: Ken Brown
Subject: Re: ptsname_r on Cygwin
Date: Thu, 21 Jan 2021 13:21:44 -0500
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1

Hi Bruno,

On 1/20/2021 1:31 AM, Bruno Haible wrote:
Hi Ken,

On Cygwin 2.9 (64-bit) I see a test failure in test-ptsname_r.c, here:

   {
     char buffer[256];
     int result;

     result = ptsname_r (-1, buffer, sizeof buffer);
     ASSERT (result != 0);  // <======================== HERE
     ASSERT (result == EBADF || result == ENOTTY);
   }

While https://www.kernel.org/doc/man-pages/online/pages/man3/ptsname_r.3.html
says that ptsname_r, upon failure, should return an error code, on Cygwin,
it returns 0 and stores the empty string in 'buffer'.

This causes 2 test failures of Gnulib tests:


FAIL: test-ptsname
==================

../../gltests/test-ptsname.c:76: assertion 'result == NULL' failed
FAIL test-ptsname.exe (exit status: 134)

FAIL: test-ptsname_r
====================

../../gltests/test-ptsname_r.c:126: assertion 'result != 0' failed
FAIL test-ptsname_r.exe (exit status: 134)

Thanks for the report.  I've submitted a patch that fixes this:

  https://cygwin.com/pipermail/cygwin-patches/2021q1/010995.html

Ken



reply via email to

[Prev in Thread] Current Thread [Next in Thread]