Re: conflicting types in windows-spawn

[Bruno Haible]

Hi,

Markus Mützel wrote:
> On second thought, the header should probably better not re-define 
> STARTUPINFO.
> The following alternative change might be saver:
> 
> From 84df3e82f88799d211bd4f5147473b238937d458 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Markus=20M=C3=BCtzel?= <markus.muetzel@gmx.de>
> Date: Thu, 6 May 2021 15:20:30 +0200
> Subject: [PATCH] windows-spawn: Don't assume that UNICODE is not defined
> 
> * lib/windows-spawn.h: Use ANSI structure STARTUPINFOA.
> ---
>  lib/windows-spawn.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/windows-spawn.h b/lib/windows-spawn.h
> index 1c29d1b17..9bcfb1c82 100644
> --- a/lib/windows-spawn.h
> +++ b/lib/windows-spawn.h
> @@ -116,7 +116,7 @@ extern int init_inheritable_handles (struct 
> inheritable_handles *inh_handles,
>     Returns 0 upon success.  In case of failure, -1 is returned, with errno 
> set.
>   */
>  extern int compose_handles_block (const struct inheritable_handles 
> *inh_handles,
> -                                  STARTUPINFO *sinfo);
> +                                  STARTUPINFOA *sinfo);
>  
>  /* Frees the memory held by a set of inheritable handles.  */
>  extern void free_inheritable_handles (struct inheritable_handles 
> *inh_handles);
> 

Yes, I agree. That's the proper way to fix it. I applied and pushed your change.
Thanks!

Bruno