Re: [PATCH] base32, base64: prefer signed to unsigned integers

[Paul Eggert]

On 8/28/21 5:45 AM, Bruno Haible wrote:

> There are two problems with this patch:
>
> 1) $ ./gnulib-tool --create-testdir --dir=../testdir5 --single-configure base32 
> base64
>     prints messages
>     gnulib-tool: warning: module base32 depends on a module with an 
> incompatible license: ialloc
>     gnulib-tool: warning: module base64 depends on a module with an 
> incompatible license: ialloc
>
>     The obvious fix would be to change the license of 'ialloc' from LGPL to 
> LGPLv2+.

Sure, done in first attached patch.

> 2) The continuous integration reported a test failure (both with GCC and clang):
>
>     test-base64.c:131: assertion 'len == 0' failed
>     FAIL test-base64 (exit status: 134)
>
>     But, strangely, I can't reproduce it locally. (Maybe it depends on the glibc
>     version?)

There is a portability issue in that code, which I fixed by installing 
the second attached patch. I hope it fixes the problem you observed.

0001-ialloc-relicense.patch
Description: Text Data

0002-base32-base64-fix-broken-tests.patch
Description: Text Data