Re: [PATCH] base32, base64: prefer signed to unsigned integers

[Paul Eggert]

On 8/29/21 3:16 AM, Bruno Haible wrote:

> There may be invocations out there, of this
> function, with an argument between SIZE_MAX/2 and SIZE_MAX-1. Changing
> such calls to be undefined behaviour means that these invocations now
> need debugging in the packages that contain them.

Luckily these calls are not present in practical code (as opposed to 
artificial test cases).

> IMO, it would be better to have code like this in base64_encode_alloc:
>
>   if (inlen < 0)
>     /* This argument is invalid, since the API change from 2021-08-28.  */
>     abort ();

Another possibility would be to treat inlen < 0 the same as integer 
overflow. I could go either way.