bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 05/10] Make gnulib's regcomp not abort()


From: Paul Eggert
Subject: Re: [PATCH v2 05/10] Make gnulib's regcomp not abort()
Date: Fri, 3 Dec 2021 20:11:03 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0

On 12/1/21 19:20, Paul Eggert wrote:
On 12/1/21 13:02, Robbie Harwood wrote:
@@ -1099,7 +1099,7 @@ optimize_utf8 (re_dfa_t *dfa)
      }
      break;
        default:
-    abort ();
+    break;
        }

Likewise, it's not clear why this change is needed. The 'abort' should not be reachable.

Is the intent to make the code a bit smaller by avoding calls to 'abort'?

A followup idea: would it help to replace 'abort ()' with 'DEBUG_ASSERT (false)', or to replace 'if (!X) abort ();' with 'DEBUG_ASSERT (X);'?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]