[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] doc: Fix example for all Win32 compiler
|
From: |
Biswapriyo Nath |
|
Subject: |
Re: [PATCH] doc: Fix example for all Win32 compiler |
|
Date: |
Wed, 29 Dec 2021 14:18:28 +0530 |
Thanks for the review. AFAIK, HAVE_VISIBILITY is specific to autotools
and it is not defined by the compiler itself. But _WIN32 is defined in
the compiler targeting Win32 platform. Using that _WIN32 logic will
not be dependent on compiler and build toolchain. Also, clang in mingw
does not define _MSC_VER. gcc documentation also suggests to use
_WIN32[1].
[1]: https://gcc.gnu.org/wiki/Visibility