Re: uninorm/composition.c:75:22: runtime error

[Simon Josefsson]

Bruno Haible <bruno@clisp.org> writes:

> I could rewrite this line as
>
>             codes[2] = (char) (unsigned char) (uc1 & 0xff);

Here is the slightly smaller local patch I am using:

https://gitlab.com/libidn/libidn2/-/commit/d792d91eb7197691cd3d2878b110c4d5ce58b2a9#7257b9bace195314d2201030e03b7ee2b83e4c83

Below that is a patch for another UBSAN complaint about a NULL + 0
operation -- I recall that being discussed before too, but don't recall
the conclusion.

> but this would be adding redundant casts, which - as Paul often remarks -
> hamper maintainability.

I agree -- it may be a clang UBSAN problem instead.

/Simon

signature.asc
Description: PGP signature