[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] sigsegv: Fix build on ppc/musl
From: |
Sam |
Subject: |
Re: [PATCH] sigsegv: Fix build on ppc/musl |
Date: |
Sun, 13 Mar 2022 16:14:41 +0000 |
> On 13 Mar 2022, at 14:17, Bruno Haible <bruno@clisp.org> wrote:
>
> Eric Blake wrote:
>> On Wed, Mar 09, 2022 at 11:37:14PM -0800, Khem Raj wrote:
>>> mcontext is not a standard layout so glibc and musl differ sadly.
>>>
>>> Fixes
>>> ../../m4-1.4.19/lib/sigsegv.c: In function 'sigsegv_handler':
>>>
>>> ../../m4-1.4.19/lib/sigsegv.c:223:75:
>>> error: 'mcontext_t' has no member named 'uc_regs'; did you mean 'gregs'?
>>>
>>> 223 | # define SIGSEGV_FAULT_STACKPOINTER ((ucontext_t *)
>>> ucp)->uc_mcontext.uc_regs->gregs[1]
>>> |
>>> ^~~~~~~
>>
>> Thanks for the report. As this file comes from gnulib, the fix needs
>> to go there first.
>
> Thanks for the report. I'm adding this patch to GNU libsigsegv:
> https://git.savannah.gnu.org/gitweb/?p=libsigsegv.git;a=commitdiff;h=a6ff69873110c0a8ba6f7fd90532dbc11224828c
>
> and then this (derived) patch to Gnulib.
>
> I couldn't verify that it works, since there is no Linux distro that is based
> on musl libc and is ported to Linux/powerpc (32-bit).
There's at least Gentoo, Adélie, and at least for now, Void.
Thanks for adding the patch and thanks to Khem for reporting it.
Best,
sam
signature.asc
Description: Message signed with OpenPGP