|
From: | Paul Eggert |
Subject: | Re: [PATCH 1/1] regex: fix broken clang build |
Date: | Thu, 16 Jun 2022 17:17:07 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 |
On 6/16/22 16:09, Bruno Haible wrote:
This should be protected by defined __clang_major__ for the same reason that __GNUC__ has similar protection.(defined __apple_build_version__ \ ? 6000000 <= __apple_build_version__ \ : 3 < __clang_major__ + (9 <= __clang_minor__))
Also, I looked at the source code for old Clang releases for my statement in <https://lists.gnu.org/r/bug-gnulib/2022-06/msg00063.html> that support for -Wvla was added in Clang 2.8, so we can use that for __clang_major__ and __clang_minor__. I don't know which (if any) Apple build version corresponds to 2.8.
Also, is a change needed in regex.h but not regex.c because different warning flags are used to compile regex.c vs regex.h's other includers? That part is still a bit unclear to me.
[Prev in Thread] | Current Thread | [Next in Thread] |