[PATCH] maintainer-makefile: Check for incorrect DISTCHECK_CONFIGURE_FLAGS usage.

[Simon Josefsson]

I discovered use of DISTCHECK_CONFIGURE_FLAGS in Makefile.am for several
projects, but that's a user-variable and AM_DISTCHECK_CONFIGURE_FLAGS
should be used.

/Simon

From dec7194206fc1ec7db0a94472d8ece58025040c6 Mon Sep 17 00:00:00 2001
From: Simon Josefsson <simon@josefsson.org>
Date: Tue, 16 Aug 2022 17:26:56 +0200
Subject: [PATCH] maintainer-makefile: Check for incorrect
 DISTCHECK_CONFIGURE_FLAGS usage.

* top/maint.mk (sc_makefile_DISTCHECK_CONFIGURE_FLAGS): Add.
---
 ChangeLog    | 6 ++++++
 top/maint.mk | 6 ++++++
 2 files changed, 12 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index c38798745d..b639d1709d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2022-08-16  Simon Josefsson  <simon@josefsson.org>
+
+       maintainer-makefile: Check for incorrect DISTCHECK_CONFIGURE_FLAGS
+       usage.
+       * top/maint.mk (sc_makefile_DISTCHECK_CONFIGURE_FLAGS): Add.
+
 2022-08-16  Bruno Haible  <bruno@clisp.org>
 
        tempname: Add tests.
diff --git a/top/maint.mk b/top/maint.mk
index c1fdf9ca2c..5745d5831d 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -1256,6 +1256,12 @@ sc_makefile_path_separator_check:
        halt=$(msg)                                                     \
          $(_sc_search_regexp)
 
+sc_makefile_DISTCHECK_CONFIGURE_FLAGS:
+       @prohibit='^DISTCHECK_CONFIGURE_FLAGS'                          \
+       in_vc_files='akefile|\.mk$$'                                    \
+       halt="use AM_DISTCHECK_CONFIGURE_FLAGS"                         \
+         $(_sc_search_regexp)
+
 # Check that 'make alpha' will not fail at the end of the process,
 # i.e., when pkg-M.N.tar.xz already exists (either in "." or in ../release)
 # and is read-only.
-- 
2.30.2

signature.asc
Description: PGP signature