>From 45b3978734eb20b5d7642dba5560c660782916c4 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Fri, 5 Aug 2022 17:13:20 +0200 Subject: [PATCH 04/12] gnulib-tool.py: Fix 'Unused import' warnings. * gnulib-tool.py: Remove unused imports. * pygnulib/*.py: Likewise. --- ChangeLog | 4 ++++ gnulib-tool.py | 5 +++-- pygnulib/GLConfig.py | 4 ---- pygnulib/GLEmiter.py | 4 ---- pygnulib/GLError.py | 4 ---- pygnulib/GLFileSystem.py | 3 --- pygnulib/GLImport.py | 5 ----- pygnulib/GLInfo.py | 2 -- pygnulib/GLMakefileTable.py | 7 ------- pygnulib/GLTestDir.py | 4 ---- 10 files changed, 7 insertions(+), 35 deletions(-) diff --git a/ChangeLog b/ChangeLog index 1d3630beea..e838c4610c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2022-08-05 Bruno Haible + gnulib-tool.py: Fix 'Unused import' warnings. + * gnulib-tool.py: Remove unused imports. + * pygnulib/*.py: Likewise. + gnulib-tool.py: Fix 'Undefined variable' errors. * pygnulib/constants.py: Import codecs. * pygnulib/GLConfig.py (GLConfig.setLibName): Fix local variable diff --git a/gnulib-tool.py b/gnulib-tool.py index c4386133a6..4e5a87d4f2 100755 --- a/gnulib-tool.py +++ b/gnulib-tool.py @@ -29,6 +29,9 @@ # You can use this command to check the style: # $ pycodestyle --max-line-length=136 --ignore=E265,W503,E241,E711,E712,E201,E202,E221 gnulib-tool.py pygnulib/*.py +# You can use this command to check for mistakes: +# $ pylint --disable=C0103,C0114,C0121,C0209,C0301,C0302,R0902,R0912,R0913,R0914,R0915,R1705,R1702,R1720 gnulib-tool.py pygnulib/*.py + #=============================================================================== # Define global imports @@ -38,11 +41,9 @@ import re import sys import codecs import random -import shutil import argparse import subprocess as sp from tempfile import mktemp -from pprint import pprint from pygnulib import constants from pygnulib import classes diff --git a/pygnulib/GLConfig.py b/pygnulib/GLConfig.py index cda218e423..baf61029c9 100644 --- a/pygnulib/GLConfig.py +++ b/pygnulib/GLConfig.py @@ -17,12 +17,8 @@ # Define global imports #=============================================================================== import os -import re -import sys import copy -import codecs import tempfile -import subprocess as sp from . import constants from .GLError import GLError diff --git a/pygnulib/GLEmiter.py b/pygnulib/GLEmiter.py index b547fde7e7..97bb585e3f 100644 --- a/pygnulib/GLEmiter.py +++ b/pygnulib/GLEmiter.py @@ -18,19 +18,15 @@ #=============================================================================== import os import re -import sys import codecs -import shutil import subprocess as sp from . import constants from .GLInfo import GLInfo -from .GLError import GLError from .GLConfig import GLConfig from .GLModuleSystem import GLModule from .GLModuleSystem import GLModuleTable from .GLMakefileTable import GLMakefileTable from .GLFileSystem import GLFileAssistant -from pprint import pprint #=============================================================================== diff --git a/pygnulib/GLError.py b/pygnulib/GLError.py index a366da5b1a..c736e423af 100644 --- a/pygnulib/GLError.py +++ b/pygnulib/GLError.py @@ -17,10 +17,6 @@ # Define global imports #=============================================================================== import os -import re -import sys -import locale -import codecs from . import constants diff --git a/pygnulib/GLFileSystem.py b/pygnulib/GLFileSystem.py index 9e6161a24d..bee38223d5 100644 --- a/pygnulib/GLFileSystem.py +++ b/pygnulib/GLFileSystem.py @@ -17,10 +17,7 @@ # Define global imports #=============================================================================== import os -import re -import sys import codecs -import shutil import filecmp import subprocess as sp from enum import Enum diff --git a/pygnulib/GLImport.py b/pygnulib/GLImport.py index 3b2b14eb4b..bf8171ea6b 100644 --- a/pygnulib/GLImport.py +++ b/pygnulib/GLImport.py @@ -18,16 +18,11 @@ #=============================================================================== import os import re -import sys -import locale import codecs -import shutil -import filecmp import subprocess as sp from . import constants from .GLError import GLError from .GLConfig import GLConfig -from .GLModuleSystem import GLModule from .GLModuleSystem import GLModuleTable from .GLModuleSystem import GLModuleSystem from .GLFileSystem import GLFileSystem diff --git a/pygnulib/GLInfo.py b/pygnulib/GLInfo.py index 5e386e7c34..b2d4457a5f 100644 --- a/pygnulib/GLInfo.py +++ b/pygnulib/GLInfo.py @@ -18,8 +18,6 @@ #=============================================================================== import os import re -import sys -import locale import codecs import subprocess as sp from . import constants diff --git a/pygnulib/GLMakefileTable.py b/pygnulib/GLMakefileTable.py index c4fb6d195a..abaeaf9d2e 100644 --- a/pygnulib/GLMakefileTable.py +++ b/pygnulib/GLMakefileTable.py @@ -17,15 +17,8 @@ # Define global imports #=============================================================================== import os -import re -import sys -import codecs -import hashlib -import subprocess as sp from . import constants -from .GLError import GLError from .GLConfig import GLConfig -from .GLFileSystem import GLFileSystem #=============================================================================== diff --git a/pygnulib/GLTestDir.py b/pygnulib/GLTestDir.py index db74b9b4e3..757c494011 100644 --- a/pygnulib/GLTestDir.py +++ b/pygnulib/GLTestDir.py @@ -19,15 +19,11 @@ import os import re import sys -import locale import codecs -import shutil -import filecmp import subprocess as sp from . import constants from .GLError import GLError from .GLConfig import GLConfig -from .GLModuleSystem import GLModule from .GLModuleSystem import GLModuleTable from .GLModuleSystem import GLModuleSystem from .GLFileSystem import CopyAction -- 2.34.1