bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: dfa tests: Fix test failure on mingw


From: Bruno Haible
Subject: Re: dfa tests: Fix test failure on mingw
Date: Tue, 25 Apr 2023 12:55:39 +0200

I did:
> +  set_binary_mode (STDOUT_FILENO, O_BINARY);

Oops, that produces a compilation error (reported by the 'grep' CI and
the 'sed' CI):

../../gltests/test-dfa-match-aux.c: In function ‘main’:
../../gltests/test-dfa-match-aux.c:61:20: error: ‘STDOUT_FILENO’ undeclared 
(first use in this function)
   61 |   set_binary_mode (STDOUT_FILENO, O_BINARY);
      |                    ^~~~~~~~~~~~~

Fixed like this:


2023-04-25  Bruno Haible  <bruno@clisp.org>

        dfa tests: Fix compilation error (regression 2023-04-22).
        * tests/test-dfa-match-aux.c: Include unistd.h.
        * modules/dfa-tests (Depends-on): Add unistd.

diff --git a/modules/dfa-tests b/modules/dfa-tests
index c4585fdf45..982d370171 100644
--- a/modules/dfa-tests
+++ b/modules/dfa-tests
@@ -9,6 +9,7 @@ binary-io
 stdio
 stdlib
 string
+unistd
 regex
 
 configure.ac:
diff --git a/tests/test-dfa-match-aux.c b/tests/test-dfa-match-aux.c
index cef29e6a83..bbe246836e 100644
--- a/tests/test-dfa-match-aux.c
+++ b/tests/test-dfa-match-aux.c
@@ -22,6 +22,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <unistd.h>
 #include <regex.h>
 #include <dfa.h>
 #include <localeinfo.h>






reply via email to

[Prev in Thread] Current Thread [Next in Thread]