[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: patch to common.make for cygwin paths
From: |
Nicola Pero |
Subject: |
Re: patch to common.make for cygwin paths |
Date: |
Tue, 6 Nov 2001 10:58:54 +0000 (GMT) |
hi,
I don't know if your patch actually does something useful because I don't
know much about windows ... :-) I'll wait for Adam - who knows about
windows - to rule on this matter_
but I want to address immediately the performance problems it might cause
[on unix machines as well] ... running subshells and firing sed commands
must be avoided in the processing mainstream ... I'd rather remove the
check altogether if that is the only way of performing it_
we might either completely remove the check at all on all machines, or
disable it on windows [and any other system where it is too
computationally expensive], or you need to figure out a way to perform the
check without running additional subshell commands_
the check is pretty irrelevant, and I added it because it was so
computationally cheap on unix ... and hoped it might prevent some unaware
people from complaining that the test service in gnustep-gui didn't work
because they hadn't run the GNUstep.sh script ... or had run it but then
messed so much with users that they no longer had the GNUstep tools in
their path ... but I have nothing particular against completely removing
the check if it is too expensive to perform_
my preferred solution would be to enclose the check into a
ifneq ($(findstring cygwin, $(GNUSTEP_TARGET_OS)), cygwin)
endif
so that it is not performed at all on windows, and is performed only on
systems were it is irrelevantly quick_
comments appreciated_
- patch to common.make for cygwin paths, Stephen Brandon, 2001/11/05
- Re: patch to common.make for cygwin paths,
Nicola Pero <=
- Re: patch to common.make for cygwin paths, Stephen Brandon, 2001/11/06
- Re: patch to common.make for cygwin paths, Adam Fedor, 2001/11/06
- Re: patch to common.make for cygwin paths, Stephen Brandon, 2001/11/06
- Re: patch to common.make for cygwin paths, Nicola Pero, 2001/11/06
- Re: patch to common.make for cygwin paths, Stephen Brandon, 2001/11/07
- Re: patch to common.make for cygwin paths, Nicola Pero, 2001/11/07
- Re: patch to common.make for cygwin paths, Nicola Pero, 2001/11/08