Re: Make package fixes (fwd)

[Nicola Pero]

Hi,

> > I'll probably apply patches to quote most shell paths in next days ...
> > even if it won't be enough to really support paths/filenames containing
> > whitespaces in it, it's a start. :-)
> 
> In the meantime I've found a bug in executable.template. The part which
> tries to find the appname in Info-gnustep.plist fails (before correcting
> the quoting it did not even do anything), because if the value of
> NSExecutable is not between quotes in the plist file, it leaves the
> trailing semicolon in appname.

Thanks - good spot - I had found that bug too in the meanwhile, and I had
fixed it by fixing the quotes and removing the ';' as well.  Your fix is
better.


> It could be fixed by simply adding a semicolon to the sed command but 
> the whole thing can be done entirely with sed. 

I think this is a great idea - thanks for contributing it !

I committed to CVS a rewriting using only sed ... I changed a bit the
regexp code to make it more precise and more portable, it looks like
working very well.

if you don't have CVS, please have a look at

http://savannah.gnu.org/cgi-bin/viewcvs/gnustep/gnustep/core/make/

to see exactly the changes I applied to CVS - let me know if it doesn't
satisfy you.



> I'm not sure about automake, but this is generally done using make's VPATH
> feature. The attached patch allows gnustep-make itself to be compiled in
> another directory, 

Thanks - I added this.