Re: Scrub last - better patch....

[Richard Frith-Macdonald]

On Thursday, September 11, 2003, at 02:09 AM, Alexander Malmberg wrote:

> This patch seems to have broken parts of the string handling. When I
> tried running the test suite today, it not only failed, it dumped core
> during the string tests.

I re-ran the tests and it was fine ... then I checked and found that I 
must have
done a 'make debug=yes' rather than a 'make debug=yes install' to build 
the
base library so the testsuite was picking up the old version of the 
library :-(

> Our test suite isn't complete in any way, but it does cover a lot of
> things, and a fair amount of important stuff. I'd like to strongly
> suggest that it be run before committing changes (if not all, then at
> least for large changes, and periodically otherwise). Bugs that cause
> regressions are bugs that could have been easily avoided.

Yes ... and make sure that you are testing what you want to be testing!

The current code in CVS passes the tests ... I spent a few hours going
through and checking/fixing.