Re: [PATCH] Rewritten NSComboBox implementation

[Quentin Mathé]

Le 17 mai 04, à 02:46, Quentin Mathé a écrit :

> Le 17 mai 04, à 02:27, Fred Kiefer a écrit :
>
> > Quentin Mathé wrote:
> > > The current implementation support both NSTableView or NSBrowser to 
> > > display the list. By default a table view is used but a flag in 
> > > NSComboBoxCell.m permits to switch to a browser. I think that both 
> > > NSBrowser and NSTableView returns wrong row/cell size and intercell 
> > > space, such issues needs to be fixed because we obtain a list which 
> > > is not sized in an exactly correct manner and doesn't respect the 
> > > visible items property precisely.
> >
> > Could you please explain, why you support both different 
> > implementations? And which one is the better, that is, worthwhile to 
> > keep? GNUstep used to have a browser, whereas Apple uses a table 
> > view, if I remember correctly.
>
> Simply because when I started, I encountered problems with NSBrowser, 
> then I have switched to NSTableView. Finally I have discovered other 
> issues as I said with the both controls : I have kept them in order to 
> be able to switch to the one which will be corrected the first. If you 
> take a look closely you can see that I have not indented the code to 
> be able to remove the not needed parts easily. Personally I'm inclined 
> to keep only NSTableView, but I haven't really an opinion on the 
> subject and you have may be other arguments to favor NSBrowser…

Is everybody ok now to apply this set of patches ? (See my first mail 
for the patches)
What do you think of my combo box/completion box idea/implementation ?

Quentin.

--
Quentin Mathé
qmathe@club-internet.fr