Re: GNUstep Printing Backend Patch and such

[Fred Kiefer]

Chad Hardin wrote:
> On Jul 5, 2004, at 12:33 AM, Fred Kiefer wrote:
> > - You removed all the ivars and some of the enumerators in the header  
> > files. The ivars are fine, but even when GNUstep stops using the  
> > enumerator we need to supply them, as some OpenStep application may  
> > still rely on them and we don't want to frustrate a user. No big 
> > deal,  as enums don't directly result in any code. You did copy these 
> > enums  to the headers of the implementation files so there really was 
> > no  gain.
>
>
> At first, I was going to make all the NS classes very abstract.  The  
> thinking was that the differences between the UNIX type bundles and a  
> Win32 bundle would be very great.  However, on second thought, I moved  
> quite a few ivars and some of the private methods from GSLPR back to  
> the NS classes.  I did this after I emailed this patch.  This allows  
> more code sharing between the GSLPR bundle and the future GSCUPS  
> bundle.  My logic is that a Win32 bundle will be so completely  
> different that it will have to re-implement almost everything anyhow.   
> So, rather than having some wacky three layered class architecture, I  
> just put some more functionality back into the NS classes.
>
> I'm afraid I'm not sure what your talking about in your reference to  
> enumerators.  Would you please explain this further?

As it is late over here, just an answer to this: There were a few 
unnamed enumerators with named constants. I don't expect that anybody 
may miss them, still they used to be in the standard. For example:

enum {
  NSPPSaveButton        = 3,
  NSPPPreviewButton     = 4,
  NSFaxButton           = 5,
  NSPPTitleField        = 20,
  NSPPImageButton       = 21,
  NSPPNameTitle         = 22,
  NSPPNameField         = 23,
  NSPPNoteTitle         = 24,
  NSPPNoteField         = 25,
  NSPPStatusTitle       = 26,
  NSPPStatusField       = 27,
  NSPPCopiesField       = 28,
  NSPPPageChoiceMatrix  = 29,
  NSPPPageRangeFrom     = 30,
  NSPPPageRangeTo       = 31,
  NSPPScaleField        = 32,
  NSPPOptionsButton     = 33,
  NSPPPaperFeedButton   = 34,
  NSPPLayoutButton      = 35,
  NSPPResolutionButton  = 36,
  NSPPOptionOKButton    = 40
};

Fred