[bugs #11624] GDL2 errors on deleted columns in PostgreSQL tables

[David Ayers]

This is an automated notification sent by Savannah.
It relates to:
                bugs #11624, project GNUstep

==============================================================================
 LATEST MODIFICATIONS of bugs #11624:
==============================================================================

               Posted by: David Ayers <ayers>
               Posted on: 2005-01-18 12:26 (Europe/Vienna)
    _______________________________________________________

                  Status:               Need Info -> Fixed                  
             Open/Closed:                    Open -> Closed                 

    _______________________________________________________

Follow-up Comment:
Fixed with:

2005-01-18  Peter Cooper  <xxx@xxx.xxx>



* EOAdaptors/Postgres95/Postgres95Channel.m

  ([-_describeBasicEntityWithName:forModel:]): Ignore droped

  columns.



==============================================================================
 OVERVIEW of bugs #11624:
==============================================================================

URL:
  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=11624>

                 Summary: GDL2 errors on deleted columns in PostgreSQL tables
                 Project: GNUstep
            Submitted by: comrade
            Submitted on: Mon 01/17/2005 at 18:58
                Category: gdl2
                Severity: 5 - Average
              Item Group: Bug
                  Status: Fixed
                 Privacy: Public
             Assigned to: ayers
             Open/Closed: Closed

    _______________________________________________________


When connecting to a PostgreSQL database which contains tables  with deleted
columns, an exception is raised due to illegal characters in the placeholders
for the deleted columns.



The Postgres95 (why is it called this?) adaptor should ignore these
placeholder columns.



A simple patch to Postgres95Channel.m is attached. The patch is cautious and
uses the ILIKE operator, rather than the LIKE operator to avoid
capitalisation issues depending on encoding and capitalisation rules. There
may be a small performance hit, but it should be safer.

    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Tue 01/18/2005 at 12:26       By: David Ayers <ayers>
Fixed with:

2005-01-18  Peter Cooper  <xxx@xxx.xxx>



* EOAdaptors/Postgres95/Postgres95Channel.m

  ([-_describeBasicEntityWithName:forModel:]): Ignore droped

  columns.



-------------------------------------------------------
Date: Tue 01/18/2005 at 11:06       By: Peter Cooper <comrade>
Of course you're right. There is a better way to identify a dropped column:
check the pg_attribute.attisdropped boolean.



Attached is a much nicer patch, I hope.

-------------------------------------------------------
Date: Tue 01/18/2005 at 10:20       By: David Ayers <ayers>
Thanks for the patch!  I'm a bit reluctant to commit it as it is.  Have you
checked whether there is some more deterministic way to figure out if a
column has been droped?   I have a hard time to imagine that PostgreSQL uses
this kind of ILIKE comparison on the attribute name to identify droped
columns internally.  But if it turns out to be that way, I'll commit it.



As to why the adaptor is still called Postgres95, well simply put, other
things have simply been higher on my TODO and currently RL is keeping me
pretty tied up.  If someone would like to rework the code to a new
PostrgreSQL Adaptor and rework the internal code, I'd be gratefull.  (I've
started a few times but never reached anything worthwhile to commit.)  But
please insure that the adaptor will work with versions 7.4.(latest) and
above.









    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 01/18/2005 at 11:06  Name: new-dropped-columns.diff  Size: 961B  
By: comrade
Updated patch to use the pg_attribute.attisdropped boolean
<http://savannah.gnu.org/bugs/download.php?item_id=11624&item_file_id=2075>
-------------------------------------------------------
Date: Mon 01/17/2005 at 18:58  Name: ignore-deleted-columns.diff  Size: 883B 
 By: comrade
Patch for PostgreSQL adaptor to ignore deleted columns
<http://savannah.gnu.org/bugs/download.php?item_id=11624&item_file_id=2072>

==============================================================================

This item URL is:
  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=11624>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/