Re: [bugs #12299] NSMatrix segfaults on row/column removal

[Richard Frith-Macdonald]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2005-03-14 18:00:38 +0000 Fred Kiefer <fredkiefer@gmx.de> wrote:

> Looks like my first lucky try was already successful. I removed the two 
> lines 
> in _renewRows:columns:rowSpace:colSpace: that restricted the creation of 
> new 
> cells to the columns smaller than col. That did the trick and the open 
> panel 
> is working again.
> Now this was just a try and I don't know if the code is correct or not. So 
> I 
> will wait for a while until I submit that change. And try to understand a 
> bit 
> more in the meantime.

I was just about to revert my changes ...

I guess I don't understand _renewRows:columns:rowSpace:colSpace: properly
... I was under the impression that the new rows/cols values supplied as
arguments were what should be populated, and higher values (up to _maxRows
and _maxCols)
needed to be initialised as nil.

The old code was making some parts of the array be uninitialised data ...
which *must* be wrong.

Anyway ... I don't like leaving things broken ... so I suggest you commit
your change, (since it fixes things for NSOpenPanel), and we both try to
underststand exactly what the method *should* be doing.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using the GPG bundle for GNUMail

iD8DBQFCNdJnE6AJp3nmKIkRAqS9AJ9om9FdBB5XCPPBfVvAIoZatcEPQwCfQ6Rz
vCRBu90nXh5UuxSje831u6o=
=iuh8
-----END PGP SIGNATURE-----