[patch #6630] Patch to always check -isFlipped as Cocoa does rather than accessing the flag directly

[Quentin Mathé]

URL:
  <http://savannah.gnu.org/patch/?6630>

                 Summary: Patch to always check -isFlipped as Cocoa does
rather than accessing the flag directly
                 Project: GNUstep
            Submitted by: qmathe
            Submitted on: mer 03 sep 2008 17:53:02 GMT
                Category: AppKit
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

Here is a patch to ensure the flipping is always determined by calling
-isFlipped as Cocoa does instead of accessing _rFlags.flipped_view.

To take a concrete example… If an NSView subclass adds a setter
-setFlipped: and stores the flipping value in a subclass specific ivar
(instead of _rFlags.flipped_view), then -setFlipped: YES isn't handled
properly: the drawing and the resizing could behave in a really weird way.
GNUstep has this problem because it caches -isFlipped in the initializer, then
accesses the flipping value through the _rFlags.

My current workaround to this solution is to access _rFlags.flipped_view
directly on GNUstep. But this patch would eliminate this need and make GNUstep
AppKit matches Cocoa behavior.

Quentin.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: mer 03 sep 2008 17:53:02 GMT  Name: NSView-flipping.m.patch  Size: 863
o   By: qmathe

<http://savannah.gnu.org/patch/download.php?file_id=16424>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6630>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.gnu.org/