[bug #24564] build failure on solaris

[Riccardo mottola]

URL:
  <http://savannah.gnu.org/bugs/?24564>

                 Summary: build failure on solaris
                 Project: GNUstep
            Submitted by: rmottola
            Submitted on: Tue 14 Oct 2008 09:38:55 PM GMT
                Category: Base/Foundation
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

on solaris 2.5, gcc 2.95, I get:

GSSocketStream.m: In function `-[GSSocketStream
_setSocketAddress:port:family:]':
GSSocketStream.m:1394: warning: implicit declaration of function `inet_pton'
GSSocketStream.m: In function `-[GSSocketInputStream close]':
GSSocketStream.m:1683: `SHUT_RD' undeclared (first use in this function)
GSSocketStream.m:1683: (Each undeclared identifier is reported only once
GSSocketStream.m:1683: for each function it appears in.)
GSSocketStream.m: In function `-[GSSocketInputStream _dispatch]':
GSSocketStream.m:1900: warning: passing arg 4 of `getsockopt' from
incompatible pointer type

I propose the following for the SHUT_RD missing:
#ifndef SHUT_RD
#define SHUT_RD 0
#define SHUT_WR 1
#define SHUT_RDWR 2
#endif

I have seen that in old code often the numbers were used directly and the
modern manpage explicitely state that those values are hard-coded.

Or maybe a more expensive configure check should be used?





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?24564>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/