Re: [bug #32166] dynamic theme switching and in-window menu bar

[Richard Frith-Macdonald]

On 4 Feb 2011, at 17:28, Gregory John Casamento wrote:

>> The old code used to support changing in either direction, this is no
> longer true. 
> 
> I'll assume you're correct here, but this wasn't always my experience.  
> Switching themes in general has always been a very imperfect process.

I think this is only the case after people started breaking it!  Switching 
between themes dynamically used to work very well for me.
I really stopped work on Thematic because it became apparent that people 
working on code-based themes were, while doing a load of good stuff, also 
breaking stuff and clearly not using it.

>> Code to support this needs to go into GSTheme in gui. 
> 
> Yes, indeed, as I mentioned here...
> 
> "What is likely needed is some code in the deactivate method of the GSTheme
> class to remove the in-window menus from all menus when switching."

I think this should actually be done by the gui library response to changing 
the interface style ... it's not a theme-specific issue, it's an interface 
style issue.
I can change the interface style to control my menus without changing the theme 
I'm using ... well, I *used* to be able to do that, and I want to be able to do 
that again.

> I should also mention that there is additional cleanup which needs to be done
> in GSTheme's deactivate method, such as unloading all of the images from the
> theme being transitioned from...  probably by reloading the GNUstep default
> images... since the theme being transitioned to might not redefine all of the
> images.

That used to work ... perhaps it still does (I haven't tried recently) or 
perhaps it's another of the things which has been broken.