Re: [bug #38035] Off by one error in enumerating MSDOS partitions

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 20.01.2013 22:33, Andrey Borzenkov wrote:

> В Sun, 20 Jan 2013 22:26:58 +0100
> Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:
> 
>> On 09.01.2013 22:31, Vladimir Serbinenko wrote:
>>
>>> Follow-up Comment #5, bug #38035 (project grub):
>>>
>>> I will commit the patch but I want first to be sure that bigger problem 
>>> behind
>>> this patch is adressed. There are other cases when the numbering doesn't 
>>> match
>>> e.g. in presence of solaris or BSD partitions.
>>>
>>
>> Ping?
>>
> 
> Sorry, I did not realize it was the question.
> 
> Which bigger problem do you mean?

That you pass arguments to grub-install in hdX,Y syntax. It breaks in
many scenarios as there is absolutely no guarantee that Linux and GRUB
partition numbering matches.

-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature