[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Cosmetic glibc 2.2.2 and hurd cvs patches.
From: |
Marcus Brinkmann |
Subject: |
Re: Cosmetic glibc 2.2.2 and hurd cvs patches. |
Date: |
Tue, 20 Feb 2001 19:35:12 +0100 |
User-agent: |
Mutt/1.1.4i |
On Sun, Feb 18, 2001 at 02:27:47AM +0200, Arkadi E. Shishlov wrote:
> Index: hurd/fstests/fstests.c
> ===================================================================
> RCS file: /cvs/hurd/fstests/fstests.c,v
> retrieving revision 1.22
> diff -u -r1.22 fstests.c
> --- hurd/fstests/fstests.c 2000/03/27 04:10:17 1.22
> +++ hurd/fstests/fstests.c 2001/02/17 23:02:45
> @@ -84,8 +84,10 @@
> perror ("2nd mkdir");
> if (rename ("/newdir2", "/foo"))
> perror ("2nd rename");
> + /*
> if (sync ())
> perror ("sync");
> + */
> #endif
>
> printf ("All done.\n");
Can you explain the above change?
> Index: hurd/libshouldbeinlibc/timefmt.c
> ===================================================================
> RCS file: /cvs/hurd/libshouldbeinlibc/timefmt.c,v
> retrieving revision 1.12
> diff -u -r1.12 timefmt.c
> --- hurd/libshouldbeinlibc/timefmt.c 1996/07/27 00:58:42 1.12
> +++ hurd/libshouldbeinlibc/timefmt.c 2001/02/17 23:02:46
> @@ -20,7 +20,7 @@
>
> #include <stdio.h>
> #include <string.h>
> -#include <sys/time.h>
> +#include <time.h>
>
> #include "timefmt.h"
>
It's correct that time.h should be included, but we also need sys/time.h
(for struct timeval for example). I made the change accordingly.
It would be nice if you could provide ChangeLog entries with your changes,
which we cn cut&paste into the file. It also makes it easier for us to see
what you are changing in your patch (ok, in this case it is easy enough).
Thanks,
Marcus
--
`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann GNU http://www.gnu.org marcus@gnu.org
Marcus.Brinkmann@ruhr-uni-bochum.de
http://www.marcus-brinkmann.de