Re: Fatfs patch for writing support

[Marco Gerards]

Marcus Brinkmann <Marcus.Brinkmann@ruhr-uni-bochum.de> writes:

Thanks for you comments Marcus, I've uploaded the new patch and
changelog entry to savannah.

> > 2003-07-07  Marco Gerards  <metgerards@student.han.nl>
> > 
> >     * node-create.c: New file.
> 
> It would be nice to have a comment in that file (like, before the actual
> content) why we need to override this from libdiskfs.  IE, explain the main
> difference in operation.

I've added it after the GPL notice.

> We don't repeat the function name this way, just list all changes in one
> entry.

>       
> >     (diskfs_rewrite_hard): Function rewritten.
> >     
> >     (diskfs_dirempty): Change logic to test if a file was deleted.
> 
> I don't like the empty lines here, with no new "* dir.c".  Either they are
> different changes and require a new "*", or they belong together.  In this
> case, I suggest to just lump everything together.  They are lots of small
> cleanups for one goal, write support.

Hmm... ok...
        
> >     * fat.c (fat_extend_chain): Move spin_lock to prevent deadlock.
> 
> This one is wrong, you must not access dn->length_of_chain without holding
> the lock (the caller only has the reader lock of alloc_lock).  So just
> unlock the lock before the "return 0" in the if (because that is the bug you
> were seeing, I guess).

Fixed.


Thanks,
Marco