bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnumach, device params


From: Gianluca Guida
Subject: Re: gnumach, device params
Date: Sun, 8 Jan 2006 19:18:52 +0100

On 1/8/06, Samuel Thibault <samuel.thibault@ens-lyon.org> wrote:
> The problem is that when opening a device (device_open), the port that
> is returned to the user is &device->dev: see
> device/ds_routines.c:device_open():

Ok. The patch is functionally OK. Only thing I ask is that you add
some comment at each #if i386 specifying that it's for device
emulation layer.

I am infact planning to post ASAP a patch that uses explicit
conditionals for device emulation layer, instead of i386. This would
clarify things a lot and make me definitely happy with this patch.

Thanks,
G.

--
It was a type of people I did not know, I found them very strange and
they did not inspire confidence at all. Later I learned that I had been
introduced to electronic engineers.
                                                  E. W. Dijkstra




reply via email to

[Prev in Thread] Current Thread [Next in Thread]