Re: GNU Mach's build system (partly) reworked (was: Compile GNU Mach 1.3 drivers)

[Alfred M. Szmidt]

   2006-01-28  Thomas Schwinge  <tschwinge@gnu.org>

           * Makefile.in: Various cleanups.  Do not include $(sysdep)/Makefrag
           anymore.  Move shared and system dependent stuff out of this file.
           Include Makerules.

This says nothing about what actually changed.  `Did stuff.' would be
equally descriptive.  When someone will search for the `%.migsh_d'
target in the ChangeLog they will not be able to figure out what
happened to it.


You removed libexecdir (and maybe some other variables), why?  Doing
something like `--prefix=$(libexecdir)/foo' is always OK.  All
variables that can be substituted should be listed.  The variables
also get partially expanded, so that is one more reason to list all of
them ($(libexecdir) ==> $(exec_prefix)/libexec).


  +top_builddir = @top_builddir@../

The following is equally effective (or should be): top_builddir = ..


  +     ln -sfn $(systype) $(includedir)/mach/machine

While you're cleaning up, you could also replace ln with $(LN) (and so
on for mkdir, etc).  But that is a minor point.


  +include $(top_builddir)Makerules

That is unsafe, add a directory seperator inbetween.