Re: [patch] null-pointer exception in hurd/libpipe/pq.c

[Thomas Schwinge]

Hello!

On Sat, Jul 22, 2006 at 06:11:04PM +0200, Stefan Siegl wrote:
> pipe_send (from libpipe/pipe.c) calls packet_write with a NULL
> pointer as the fourth argument (size_t *amount), if a control packet
> is to be sent.  However packet_write hasn't cared for the NULL
> pointer but tried to pass the appended amount of bytes back there,
> resulting in a crash of pflocal (which calls pipe_send in S_socket_send). 

How / why did this happen for you and why didn't it happen for other
people in the past?


> This patch checks whether amount is NULL and doesn't write the value
> back in case.

I checked in the following:

#v+
2006-07-25  Stefan Siegl  <stesie@brokenpipe.de>

        * pq.c (packet_write): Only dereference AMOUNT if it is not the null
        pointer and document the change.
        * pq.h (packet_write): Document the change.
#v-


Thanks for your contribution!


Regards,
 Thomas