bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Entropy Patch (as an attachment)


From: Michael Casadevall
Subject: Re: Entropy Patch (as an attachment)
Date: Sun, 5 Aug 2007 16:20:09 -0400 (EDT)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

GCC should turn that to whatever the size of io_req_t is when compiled; if io_req_t was to change at any point, then when mach is recompiled, that won't break. Unless I'm misunderstanding your point.
Michael

On Mon, 6 Aug 2007, Samuel Thibault wrote:

Hi,

Neal H. Walfield, le Mon 06 Aug 2007 19:56:30 +0200, a écrit :
+#ifdef MACH_ENTROPY
+           /*  Let's grab the cylinder numbers for entropy */
+           entropy_putdata (prev, sizeof(io_req_t));
+#endif

sizeof will always give the same value.  Is this really what you want
to do here?

Mmm, he's giving a pointer and a size, isn't he?

Samuel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU)

iD8DBQFGtjD5V/FBeJ6jsZQRAt5cAJ9sZri+vINLQ7B1YALr+oAVc+pFKQCfa9eD
nppBOn1SkeZHEDNoVCNdxhE=
=LfmP
-----END PGP SIGNATURE-----

reply via email to

[Prev in Thread] Current Thread [Next in Thread]