Re: Making DHCP renew work in pfinet

[Michael Banck]

On Mon, Oct 22, 2007 at 11:03:49PM +0200, Christian Dietrich wrote:
> * Stefan Siegl <stesie@brokenpipe.de> [Oct 15 2007 23:57] wrote:
> > > But now, when the /etc/dhclient-script calls fsysopts it will override
> > > all other device informations, e.g. ipv6 addresses, gateways on other
> > > devices. So i changed the commandline/fsysopts interface of pfinet a
> > > little bit: when we call `fsysopts /servers/socket/2 -i eth0 -a
> > > 192.168.7.1` the address of eth1 isn't deleted anymore, but only the
> > > address of eth0 is changed. All other values will be preserved.

Awesome! I included your patch in the Debian Hurd package.

> > > The whitespaces beetween -a and the ip are missing because -a, -g, -m,
> > > -p, -A, -G have only optional arguments. If the argument is no passed
> > > the value will be unset e.g. the gateway.
> > 
> > I'm afraid, but I don't think that's a good idea.  People are used to
> > passing `-a 192.168.7.5' or similar and the provided IP addresses can be
> > distinguished quite easily.

Yeah, thanks for taking care of that.

> now '-a 192.168.100.1' '-a192.168.100.1' '-a' are possible
> so i didn't have to touch /etc/dhclient-script at all

> > >  if [ x$reason = xPREINIT ]; then
> > > -  settrans -afg /servers/socket/2 /hurd/pfinet --dhcp -i $interface
> > >    exit_with_hooks 0

What about that --dhcp option?  Not a big deal (I'll remove it from
dhcp-client), but will it break for current users when they install the
new pfinet?

One nitpick at the diff you sent: don't include the ChangeLog in the
diff, include it detached in the mail body (otherwise, applying the diff
later will fail if the ChangeLog got written to in the meantime)


thanks,

Michael