Re: About SOCK_CLOEXEC, SOCK_NONBLOCK flags, accept4, etc.

[Thomas Schwinge]

Hello!

Just an amendment to my previous email.

On Wed, Dec 10, 2008 at 05:34:37PM +0100, I wrote:
> > CLOEXEC is purely in libc, just pass O_CLOEXEC to _hurd_intern_fd.
> 
> Really only pass flags & O_CLOEXEC or rather pass all flags and let
> _hurd_intern_fd sort out the ones it's interestied in?  That would make
> it future-proof should further flags be added (whichever).

> Linux now does allow using socket (domain, type | SOCK_*, protocol)
> calls.  Shall I change the pf* servers to cope with that (saves one RPC
> per use) or shall we filter out these SOCK_* flags (only SOCK_NONBLOCK)
> in sysdeps/mach/hurd/socket.c and do manual socket_set_option RPCs?  To
> avoid a mischmasch (accept nevertheless needs the extra call) I'd rather
> go for the latter one.

(io_set_some_openflags instead of socket_set_option, of course.)

What about in fact having do _hurd_intern_fd do the io_set_some_openflags
RPC for O_NONBLOCK?


Regards,
 Thomas

signature.asc
Description: Digital signature