Re: [PATCH 3/3] Add the mountee to the list of merged filesystems.

[olafBuddenhagen]

Hi,

On Mon, Aug 03, 2009 at 08:42:27PM +0300, Sergiu Ivanov wrote:

> diff --git a/mount.c b/mount.c
> index 45889f8..9d2a1e5 100644
> --- a/mount.c
> +++ b/mount.c
> @@ -27,6 +27,7 @@
>  
>  #include "mount.h"
>  #include "lib.h"
> +#include "ulfs.h"
>  
>  /* The command line for starting the mountee.  */
>  char * mountee_argz;
> @@ -167,6 +168,14 @@ setup_unionmount (void)
>    if (err)
>      return err;
>  
> +  /* A path equal to "" will mean that the current ULFS entry is the
> +     mountee port.  */
> +  ulfs_register ("", 0, 0);

This comment would actually be more appropriate near the definition of
the actual data structure and/or the function filling it in...

Of course, it doesn't hurt to mention it here *in addition* to that :-)

> +
> +  /* Initialize the list of merged filesystems.  */
> +  ulfs_check ();
> +  node_init_root (netfs_root_node);

The comment still doesn't explain why this is necessary.

AIUI, the list is already initialized earlier. Here, we have to do it
*again*, because we just added another element to the union, and need to
pick up the new info...

I actually wonder whether the patches are really split up in the most
useful manner... But I'd rather leave it as is now.

-antrik-