bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Porting uptimed: Usage of daemon and replacement of NOFILE


From: Svante Signell
Subject: Re: Porting uptimed: Usage of daemon and replacement of NOFILE
Date: Tue, 01 Nov 2011 23:25:13 +0100

On Tue, 2011-11-01 at 22:30 +0100, Guillem Jover wrote:
> On Tue, 2011-11-01 at 15:57:53 +0100, Svante Signell wrote:
..
> __USE_BSD is an internal macro used by glibc and should not be relied
> on. Add a check to configure.ac instead, something like this:
> 
> AC_CHECK_FUNCS([getdtablesize])

Ok, done!

> and then use HAVE_GETDTABLESIZE. Also if there's no limit (-1) it's a
> bit harsh to exit(1). I'd code this for example like:

I did not realize that -1 meant unlimited, where is this written? I
thought it indicated an error.

RETURN VALUE
 The current limit on the number of open files per process.

ERRORS
  On  Linux,  getdtablesize()  can return any of the errors described
for getrlimit(2); see NOTES below.

I expected the gettablesize to return a value of -1 indicating an error.

Updated patch attached, OK now?

Attachment: fix_FTBFS4Hurd.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]