Re: [PATCH] Disable NFS translator & daemon when Sun RPC support is missing

[Thomas Schwinge]

Hi!

On Thu, 03 Nov 2011 23:12:52 +0100, ludo@gnu.org (Ludovic 
=?iso-8859-1?Q?Court=E8s?=) wrote:
> The patch below disables building of the NFS translator and daemon when
> Sun/ONC RPC support is missing, as is the case with GNU libc 2.14+, and
> until TI-RPC actually is actually buildable on GNU.
> 
> OK to apply?

Thanks, and generally OK; some minor comments though.

(And I'm assuming you have tested this.)

> diff --git a/Makefile b/Makefile
> index ad187d0..e0ba052 100644
> --- a/Makefile
> +++ b/Makefile

OK.

> diff --git a/config.make.in b/config.make.in
> index 986ea2a..beb89d1 100644
> --- a/config.make.in
> +++ b/config.make.in
> @@ -66,6 +66,9 @@ PARTED_LIBS = @PARTED_LIBS@
>  LIBNCURSESW = @LIBNCURSESW@
>  NCURSESW_INCLUDE = @NCURSESW_INCLUDE@
>  
> +# Whether TI-RPC or GNU libc's RPC support is available.
> +HAVE_SUN_RPC = @HAVE_SUN_RPC@

Let's just say ``Sun RPC'', or what is the proper name?

> diff --git a/configure.in b/configure.in
> index 1cf4daa..283e52c 100644
> --- a/configure.in
> +++ b/configure.in

Will also need to commit an updated configure file in the same patch
(removing the automatically regeneratable files is worth a different
patch).

> +# Check for Sun RPC headers.  Sun RPC support is no longer available
> +# starting from GNU libc 2.14 and will be provided by TI-RPC.
> +# However TI-RPC has yet to be ported to GNU/Hurd:
> +# see <http://lists.debian.org/debian-hurd/2010/12/msg00007.html>.

I suggest to move the ``Sun RPC support is no longer [...]'' text into
(the largely outdated) README.CVS file, where other build requirements
are documented.  As in the config.make.in hunk, we don't need
specifically glibc or TI-RPC RPC support, but just some Sun RPC
implementation.

> +AC_CHECK_HEADER([rpc/types.h], [HAVE_SUN_RPC=yes], [HAVE_SUN_RPC=no])
> +AC_SEARCH_LIBS([clnt_create], [], [:], [HAVE_SUN_RPC=no])
> +AC_SUBST([HAVE_SUN_RPC])

In the TI-RPC case, we will need to link against an additional library, I
assume?  If yes, are you able to make an educated guess and add support
for that already now, to have it added to nfs and nfsd's link command
lines?  (So that it'll just work once TI-RPC is built, and we don't have
to revisit this issue then.)  In that case also change the text above to
``Check for Sun RPC headers and libraries''.  Compare to PARTED_LIBS
handling, but without the PARTED_FAIL stuff.  (Just no nfs and nfsd if no
RPC implementation can be found.)


Grüße,
 Thomas

pgpunxGOLVI1K.pgp
Description: PGP signature