Re: tmpfs status

[Samuel Thibault]

Thomas Schwinge, le Mon 26 Mar 2012 22:24:55 +0200, a écrit :
> > 1. 
> > http://git.savannah.gnu.org/cgit/hurd/hurd.git/log/?h=mplaneta/tmpfs/master 
> 
> Someone to review the patches...  :-/

Just a few comments.

> Fix auto-terminating of tmpfs due to idle.

Err, really?  I'd rather not see my tmpfs fly away just because I've
left it dormant for some time.

> Remove warnings during compilation.

Applied with a couple of fixes.

> Correct errors in default pager and make it work with tmpfs.

That needs more explanation about how it works.

> Correct handling of object size.

I guess why the first hooks are needed, but the last hook needs
explanation (dropping the call to default_pager_object_set_size).

> Don't panic in default_pager_object_set_size.

Ditto.  Why is it normal that it happens?

> Update comments.

Why moving the comment and not duplicating it?

> Correct available space check.

Applied.

> Add lock in pager_truncate.

Applied.

> Correct function calling.

Applied.

> Take into account that pager's map could have NULL value.

When can that happen?

> Return support of old pageout format.

AIUI, it's meant to fix the initialization issue that you raised some
time ago?

> Fix hard links accounting in tmpfs.

Applied.

> Update '..' link for directory when moving it.

It's a bit odd to have to use a special NULL value. ext2fs rather stores
the lookup_type in a type field of struct dirstat.  That looks much
better.

Thanks for your work, and looking forward your updated patches.
Samuel