Re: tmpfs status

[Thomas Schwinge]

Hi!

On Wed, 28 Mar 2012 22:40:22 +0300, Maksym Planeta <mcsim.planeta@gmail.com> 
wrote:
> Samuel Thibault <samuel.thibault@gnu.org> writes:
> 
> > Thomas Schwinge, le Mon 26 Mar 2012 22:24:55 +0200, a écrit :
> >> > 1. 
> >> > http://git.savannah.gnu.org/cgit/hurd/hurd.git/log/?h=mplaneta/tmpfs/master
> >> >  
> >> 
> >> Someone to review the patches...  :-/
> >
> > Just a few comments.
> >
> >> Fix auto-terminating of tmpfs due to idle.
> >
> > Err, really?  I'd rather not see my tmpfs fly away just because I've
> > left it dormant for some time.
> 
> I meant that now it doesn't auto-terminate.

Yes.  But that should be possible to achieve very much simpler: just put
``thread_timeout = server_timeout = 0;'' before diskfs_spawn_first_thread
is called.  (Or am I missing something?)


Skipping the other commits/comments, sorry.


> > Thanks for your work, and looking forward your updated patches.
> > Samuel
> 
> How have I make updated patches? Amend old ones, revert them and then
> make new patches, but already right or just make patches that correct
> present errors?

I think you should create a new branch, mplaneta/tmpfs/master-v2 (or
similar), based on the *current* Savannah master branch (which include
some of your mplaneta/tmpfs/master commits), and git cherry-pick the
remaining patches, and fix them as needed -- cherry-pick one, fix it up,
cherry-pick the next, etc.  Does that sound plausible?


Grüße,
 Thomas

pgpkFSD1rVUNp.pgp
Description: PGP signature