libpthread: Store self in __thread variable instead of threadvar (was: [SCM] POSIX threading library branch, master, updated. 25260994c812050a5d7addf125cdc90c911ca5c1)

[Thomas Schwinge]

Hi!

On Thu, 26 Apr 2012 23:38:56 +0000, Samuel Thibault 
<samuel.thibault@ens-lyon.org> wrote:
> commit 25260994c812050a5d7addf125cdc90c911ca5c1
> Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
> Date:   Fri Apr 27 01:32:54 2012 +0000
> 
>     Store self in __thread variable instead of threadvar

You have reverted this patch for Debian, as you had been seeing issues
(not specified/remembered in more detail), and I now have found issues
too, in libpthread's own testsuite, when running with
MALLOC_PERTURB_=161, which is of course easy and welcome for reproducing.

    Running test-1... Illegal instruction
    Failure.
    Running test-2... Success.
    Running test-3... Success.
    Running test-6... Illegal instruction
    Failure.
    Running test-7... Illegal instruction
    Failure.
    Running test-8... Illegal instruction
    Failure.
    Running test-9... Illegal instruction
    Failure.
    Running test-10... Success.
    Running test-11... Illegal instruction
    Failure.
    Running test-12... Success.
    Running test-13... Success.
    Running test-14... Success.
    Running test-15... Illegal instruction
    Failure.
    Running test-16... Illegal instruction
    Failure.
    Running test-17... Success.
    Running test-__pthread_destroy_specific-skip... Illegal instruction
    Failure.
    Running test-1-static... Illegal instruction
    Failure.
    Running test-2-static... Success.
    Running test-3-static... Success.
    Running test-6-static... Illegal instruction
    Failure.
    Running test-7-static... Illegal instruction
    Failure.
    Running test-8-static... Illegal instruction
    Failure.
    Running test-9-static... Illegal instruction
    Failure.
    Running test-10-static... Success.
    Running test-11-static... Illegal instruction
    Failure.
    Running test-12-static... Success.
    Running test-13-static... Success.
    Running test-14-static... Success.
    Running test-15-static... Illegal instruction
    Failure.
    Running test-16-static... Illegal instruction
    Failure.
    Running test-17-static... Success.
    Running test-__pthread_destroy_specific-skip-static... Illegal instruction
    Failure.

    Program received signal SIGILL, Illegal instruction.
    0x0106d80c in mach_msg_trap () at 
/home/rbraun/dev/debian/eglibc/eglibc-2.13/build-tree/hurd-i386-libc/mach/mach_msg_trap.S:2
    2       kernel_trap (__mach_msg_trap,-25,7)
    (gdb) bt
    #0  0x0106d80c in mach_msg_trap () at 
/home/rbraun/dev/debian/eglibc/eglibc-2.13/build-tree/hurd-i386-libc/mach/mach_msg_trap.S:2
    #1  0x0106e009 in __mach_msg (msg=msg@entry=0x15ff1c8, 
option=option@entry=2, send_size=send_size@entry=0, rcv_size=rcv_size@entry=24, 
        rcv_name=54, timeout=timeout@entry=0, notify=notify@entry=0) at 
msg.c:110
    #2  0x0103476e in __pthread_block (thread=thread@entry=0x8049170) at 
../Peter_Herbolzheimer/sysdeps/mach/pt-block.c:35
    #3  0x01034062 in __pthread_cond_timedwait_internal 
(abstime=abstime@entry=0x0)
        at ../Peter_Herbolzheimer/sysdeps/generic/pt-cond-timedwait.c:105
    #4  0x01033cbb in __pthread_cond_wait (cond=cond@entry=0x8145284, 
mutex=mutex@entry=0x8145264)
        at ../Peter_Herbolzheimer/sysdeps/generic/pt-cond-wait.c:36
    #5  0x01031704 in pthread_join (thread=502, status=0x15ff2e8) at 
../Peter_Herbolzheimer/pthread/pt-join.c:44
    #6  0x08048c42 in main (argc=1, argv=0x15ffbb8) at test-6.c:71

For the moment, I'm just reverting the patch locally, too, as I want to
get some other libpthread work finished first.


Grüße,
 Thomas

pgpzaOFcBexrk.pgp
Description: PGP signature