bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Questions about patches for hurdselect.c


From: Samuel Thibault
Subject: Re: Questions about patches for hurdselect.c
Date: Mon, 14 Jan 2013 01:02:31 +0100
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Svante Signell, le Sun 13 Jan 2013 21:59:23 +0100, a écrit :
> On Sun, 2013-01-13 at 21:31 +0100, Samuel Thibault wrote:
> > Svante Signell, le Sun 13 Jan 2013 21:18:07 +0100, a écrit :
> > > > - In the poll case, on error on one descriptor, the loop shall mark
> > > > POLLERR and continue, not fail altogether.
> > > > 
> > > > Is that right?
> > > 
> > > The current code errors out if it finds one FD not OK, which is a bug.
> > > Irrespective of how many FDs there are, no checks are made of the input
> > > data given.
> > 
> > Sure, but what you refer to is only one part of the story. EBADF is one
> > of the "error"s I mention above.  Errors returned by translators also
> > need the same fix.
> 
> One problem is already fixed by me and you for pflocal. Remains to fix
> the corresponding issues for pfinet. (and maybe other ones too).

I've just done it for pfinet. I had checked the others, they don't need
more fixes than they have already.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]