bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH,HURD] hurdselect: Step1, code split preparations (version 3)


From: Svante Signell
Subject: Re: [PATCH,HURD] hurdselect: Step1, code split preparations (version 3)
Date: Thu, 24 Jan 2013 12:10:05 +0100

On Wed, 2013-01-23 at 17:52 +0100, Svante Signell wrote:
> On Wed, 2013-01-23 at 00:52 +0100, Samuel Thibault wrote:
> > Svante Signell, le Tue 22 Jan 2013 20:53:06 +0100, a écrit :

> Since there was a lot of concerns about code duplication I introduced a
> helper function _wait_for_replies(), splitting out the union definitions
> and the _mach_msg() call.

Introduced another helper function: _io_select_request()
The patch does the following:
1) Create another helper function: _io_select_request() (good enough name?)
2) Sets got to -1 in case of errors and always return got in both helper
functions.

(Hopefully I got the call by value and call by reference issues right)

The patch is made against hurdselect_step1_2.c.

Next step will be to introduce the three cases: DELAY POLL, SELECT
before adding the needed changes for POLL.  

Attachment: hurdselect_step1_3.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]