[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH, gnumach] ddb: fix implicit declarations
From: |
Samuel Thibault |
Subject: |
Re: [PATCH, gnumach] ddb: fix implicit declarations |
Date: |
Fri, 5 Jul 2013 09:45:39 +0200 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Marin Ramesa, le Fri 05 Jul 2013 08:23:22 +0200, a écrit :
> On 04.07.2013 23:11:19, Samuel Thibault wrote:
> > Please rather put it into a .h file.
>
> * ddb/db_command.h (_setjmp): Add prototype.
> * kern/xpr.h (_setjmp): Add prototype.
Err, no, the point of putting it in a .h file is to put it into a single
place, so you're sure everybody agree on the definition since it's
written only once. The .h file where it's supposed to go has to be
related with the function itself, e.g. here i386/i386/setjmp.h seems
like a good candidate.
Samuel
- [PATCH, gnumach] ddb: fix implicit declarations, Marin Ramesa, 2013/07/03
- Re: [PATCH, gnumach] ddb: fix implicit declarations, Richard Braun, 2013/07/03
- Re: [PATCH, gnumach] ddb: fix implicit declarations, Samuel Thibault, 2013/07/04
- Re: [PATCH, gnumach] ddb: fix implicit declarations, Marin Ramesa, 2013/07/04
- Re: [PATCH, gnumach] ddb: fix implicit declarations, Marin Ramesa, 2013/07/05
- Re: [PATCH, gnumach] ddb: fix implicit declarations,
Samuel Thibault <=
- Re: [PATCH, gnumach] ddb: fix implicit declarations, Marin Ramesa, 2013/07/05
- Re: [PATCH, gnumach] ddb: fix implicit declarations, Marin Ramesa, 2013/07/07
- Re: [PATCH, gnumach] ddb: fix implicit declarations, Samuel Thibault, 2013/07/07
Re: [PATCH, gnumach] ddb: fix implicit declarations, Samuel Thibault, 2013/07/04