Re: [PATCH 3/7] name_equal: return early from function if src null-terminates in the loop

[Samuel Thibault]

Marin Ramesa, le Fri 13 Sep 2013 13:31:53 +0200, a écrit :
> Return early from function if src null-terminates in the loop before
> the target does. This is to prevent pointers going to addresses beyond
> null-termination.

Mmm, let me unloop it a bit:

>           if (*src++ != *target++)
>               return FALSE;
>           if (*src == '\0' && *target != '\0')
>               return FALSE;
>           if (*src++ != *target++)
>               return FALSE;

This shows that the case you added would be caught by the next iteration
of the while loop anyway, so your patch does not seem to change the
behavior?

Samuel