[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] coding style changes
From: |
Samuel Thibault |
Subject: |
Re: [PATCH 2/4] coding style changes |
Date: |
Sat, 21 Sep 2013 16:13:24 +0200 |
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Marin Ramesa, le Tue 17 Sep 2013 19:35:03 +0200, a écrit :
> @@ -421,7 +421,7 @@ device_open(reply_port, reply_port_type, mode, name,
> device_p)
> ipc_port_t reply_port;
> mach_msg_type_name_t reply_port_type;
> dev_mode_t mode;
> - char * name;
> + char *name;
> device_t *device_p; /* out */
As odd as it may seem, I believe we want to keep char * name. The
idea is that it's not a pointer on a char, but a character string.
Samuel
- Small cleanup of the device server routines, Marin Ramesa, 2013/09/17
- [PATCH 1/4] remove register qualifiers, Marin Ramesa, 2013/09/17
- [PATCH 3/4] remove lint code, Marin Ramesa, 2013/09/17
- [PATCH 2/4] coding style changes, Marin Ramesa, 2013/09/17
- Re: [PATCH 2/4] coding style changes,
Samuel Thibault <=
- [PATCH 4/4] add comments after endifs, Marin Ramesa, 2013/09/17
- Re: Small cleanup of the device server routines, Samuel Thibault, 2013/09/21