[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 31/66] i386/i386at/com.c: simplify code
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH 31/66] i386/i386at/com.c: simplify code |
|
Date: |
Mon, 9 Dec 2013 00:01:36 +0900 |
|
User-agent: |
Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) |
Marin Ramesa, le Thu 05 Dec 2013 22:03:25 +0100, a écrit :
> Variable comtimer_active is used uninitialized. What's the
> chance of this variable getting the value FALSE?
> @@ -64,7 +64,6 @@ struct tty com_tty[NCOM];
> int commodem[NCOM];
> int comcarrier[NCOM] = {0, 0,};
> boolean_t comfifo[NCOM];
> -boolean_t comtimer_active;
Simply by being a statically-allocated variable, thus defaulting to 0.
Samuel
- [PATCH 24/66] i386/i386/mp_desc.c: remove unused variable, (continued)
- [PATCH 24/66] i386/i386/mp_desc.c: remove unused variable, Marin Ramesa, 2013/12/05
- [PATCH 23/66] i386/i386/ipl.h: remove ifdef and add ifndef, Marin Ramesa, 2013/12/05
- [PATCH 26/66] i386/i386/pic.c: remove unused variables, Marin Ramesa, 2013/12/05
- [PATCH 25/66] i386/i386/mp_desc.c: remove dead assignment, Marin Ramesa, 2013/12/05
- [PATCH 27/66] i386/i386/pit.c: remove unused variables, Marin Ramesa, 2013/12/05
- [PATCH 29/66] i386/i386/trap.c: remove unused variables, Marin Ramesa, 2013/12/05
- [PATCH 28/66] i386/i386/trap.c: remove unused variable, Marin Ramesa, 2013/12/05
- [PATCH 30/66] i386/i386/user_ldt.c: remove unused variable, Marin Ramesa, 2013/12/05
- [PATCH 31/66] i386/i386at/com.c: simplify code, Marin Ramesa, 2013/12/05
- Re: [PATCH 31/66] i386/i386at/com.c: simplify code,
Samuel Thibault <=
- [PATCH 32/66] i386/i386at/com.c: remove dead assignment, Marin Ramesa, 2013/12/05
- [PATCH 33/66] i386/i386at/immc.c, kd.c: use boolean instead of an int, Marin Ramesa, 2013/12/05
- [PATCH 34/66] i386/i386at/model_dep.c, kd.c: use boolean instead of an int, Marin Ramesa, 2013/12/05
- [PATCH 40/66] i386/i386at/kd.h: remove ifdef, Marin Ramesa, 2013/12/05
- [PATCH 41/66] i386/i386at/kd.h: remove ifdef, Marin Ramesa, 2013/12/05
- [PATCH 43/66] i386/i386at/rtc.c: use boolean instead of an int, Marin Ramesa, 2013/12/05
- [PATCH 42/66] i386/i386at/lpr.c: remove uninitialized variable, Marin Ramesa, 2013/12/05