bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/28] ddb/db_aout.c (aout_db_eq_name): remove unnecessary va


From: Samuel Thibault
Subject: Re: [PATCH 08/28] ddb/db_aout.c (aout_db_eq_name): remove unnecessary variable
Date: Mon, 9 Dec 2013 00:47:55 +0900
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Marin Ramesa, le Sun 08 Dec 2013 12:40:10 +0100, a écrit :
> Variable name can be used instead of s2.

Ditto.

> * ddb/db_aout.c (aout_db_eq_name): Remove unnecessary variable.
> 
> ---
>  ddb/db_aout.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/ddb/db_aout.c b/ddb/db_aout.c
> index 5cb3911..63fa518 100644
> --- a/ddb/db_aout.c
> +++ b/ddb/db_aout.c
> @@ -152,18 +152,17 @@ aout_db_eq_name(sp, name)
>       struct nlist *sp;
>       char *name;
>  {
> -     char *s1, *s2;
> +     char *s1;
>  
>       s1 = sp->n_un.n_name;
> -     s2 = name;
> -     if (*s1 == '_' && *s2 && *s2 != '_')
> +     if (*s1 == '_' && *name && *name != '_')
>           s1++;
> -     while (*s2) {
> -         if (*s1++ != *s2++) {
> +     while (*name) {
> +         if (*s1++ != *name++) {
>               /*
>                * check .c .o file name comparison case
>                */
> -             if (*s2 == 0 && sp->n_un.n_name <= s1 - 2
> +             if (*name == 0 && sp->n_un.n_name <= s1 - 2
>                       && s1[-2] == '.' && s1[-1] == 'o')
>                   return(TRUE);
>               return(FALSE);
> -- 
> 1.8.1.4
> 
> 

-- 
Samuel
* D a decide de peter un cable dans son rapport de pfp
<c> et il a bien raison ;-)
<c> tu vas dire quoi ?
<D> j'ai mis les paroles de "le coq est mort" en en-tete
 -+- #ens-mim et la peufeupeu -+-



reply via email to

[Prev in Thread] Current Thread [Next in Thread]